New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope to identify single-quoted heredocs #159

Merged
merged 4 commits into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@Alhadis
Contributor

Alhadis commented Oct 20, 2017

Description of the Change

Just a simple, tiny fix: double-quoted heredocs are scoped with string.quoted.double.heredoc, but there's nothing to identify heredocs which are delimited by three apostrophes:

string: '''
	Heredoc
'''

UPDATE:
I've added a scope to identify multiline regular expressions, too:

regexp: ///
	(Stuff | etc)
///

Benefits

Easier targeting with stylesheets. If a user wishes to style only single-quoted heredocs, they need to resort to duplicated rulesets, or sticking :not(.double) in the selector.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 20, 2017

Member

Can you whip up two basic tests just to make sure we have test coverage of the scopes?

Member

50Wliu commented Oct 20, 2017

Can you whip up two basic tests just to make sure we have test coverage of the scopes?

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Oct 20, 2017

Contributor

Done.

Contributor

Alhadis commented Oct 20, 2017

Done.

@50Wliu 50Wliu merged commit 6a25327 into atom:master Oct 20, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Alhadis Alhadis deleted the Cutlery-Drawer:single-fix branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment