Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSX tags to the CoffeeScript grammar #172

Merged
merged 3 commits into from Jan 25, 2019

Conversation

@cuberoot
Copy link

@cuberoot cuberoot commented Oct 10, 2018

Description of the Change

In CoffeeScript 2.0, JSX tags became part of the language (https://coffeescript.org/#jsx). This change adds recognition of tags and attributes to the existing CoffeeScript grammar.

Alternate Designs

No other designs were considered as this is a simple addition to an exisiting grammar.

Benefits

This change will add syntax highlighting for JSX tags and attributes in Atom.

Possible Drawbacks

A bug could cause incorrect tokenization of CoffeeScript code and cause issues in syntax highlighting

Applicable Issues

#135

Michael Taylor added 3 commits Oct 10, 2018
In CoffeeScript 2.0, JSX tags became part of the language (https://coffeescript.org/#jsx). This change adds recognition of tags and attributes to the existing coffeescript grammar.
And, also kick the build which seems to have hiccupped
@cuberoot cuberoot mentioned this pull request Oct 22, 2018
1 task done
@rsese
Copy link
Member

@rsese rsese commented Oct 22, 2018

Thanks! Someone from the team will take a look as soon as they can.

@lee-dohm
Copy link
Member

@lee-dohm lee-dohm commented Oct 23, 2018

Thanks for the contribution! We're currently deciding the way forward for our official language packages with the advent of tree-sitter. We'll get back to you as soon as we can once we make some other decisions.

@cuberoot
Copy link
Author

@cuberoot cuberoot commented Oct 31, 2018

@lee-dohm Ok, thanks. Let me know either way. I could possibly contribute to a tree-sitter solution if you go that direction.

Copy link
Member

@smashwilson smashwilson left a comment

👍 Gave it a shot with some of the CoffeeScript JSX examples and it looks good to me. :shipit:

@smashwilson smashwilson merged commit a1ca025 into atom:master Jan 25, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@edemaine edemaine mentioned this pull request Feb 21, 2021
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants