New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't optionally match trailing newlines in comments #101

Merged
merged 2 commits into from Sep 23, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 23, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

I don't believe it's doing anything useful?

Alternate Designs

Keep the newline match and edit the tests instead.

Benefits

language-csharp tests will pass against first-mate@7.0.8+.

Possible Drawbacks

None, unless the newline match is doing something important.

Applicable Issues

atom/first-mate#100

@50Wliu 50Wliu merged commit 401193e into master Sep 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-newline-check branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment