New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black method parameters highlighting #118

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@worldbeater
Contributor

worldbeater commented Apr 19, 2018

Made some color tweaks, so now C# syntax highlighter uses black color for lambda parameters, function parameters, and private fields. Color keys are taken from scope-names.json that GitHub uses. More info on this can be found here.

Please, take a look at how it works now:

image

Not yet tested this in Atom.

@worldbeater

This comment has been minimized.

Contributor

worldbeater commented Apr 19, 2018

Tested this in atom, so far looks nice.

image

@damieng need a review.
Thanks in advance :)

@damieng

This comment has been minimized.

Contributor

damieng commented Apr 19, 2018

This looks great!! Nice job :)

@damieng damieng merged commit 171dfa1 into atom:master Apr 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment