New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csharp.cson, fix converter paths #123

Merged
merged 2 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@worldbeater
Contributor

worldbeater commented Aug 28, 2018

Description of the Change

As you know, language-csharp grammar that is used by both Atom and Github comes from upstream. So this PR updates the grammar as there were a lot of fixes and improvements since the grammar was updated last time (dotnet/csharp-tmLanguage#114 dotnet/csharp-tmLanguage#132 dotnet/csharp-tmLanguage#113 etc.)

Python script from scripts/ folder was used to keep PCRE support, it removed dashes from group names. Manual fixes were applied according to these commits: 3b93970 15df170 17f89b8 (GitHub highlighter needs them)

Before

// Here used to be bad highlighting, but now 
// changes are merged and the code looks OK!
Span<int> arr = stackalloc [] {1, 2, 3};
static void M(in S arg);
public ref struct RefStruct { }

After

C# language syntax highlighting is improved and now supports ref struct, stackalloc, etc.

image

Possible Drawbacks

None.

@damieng damieng self-requested a review Aug 28, 2018

@damieng

Really nice piece of work thanks @worldbeater !

@worldbeater

This comment has been minimized.

Show comment
Hide comment
@worldbeater

worldbeater Aug 28, 2018

Contributor

You are welcome @damieng! And thank you for reviewing this 🥇

Contributor

worldbeater commented Aug 28, 2018

You are welcome @damieng! And thank you for reviewing this 🥇

@damieng damieng merged commit e26364f into atom:master Aug 28, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment