Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Massive overhaul of grammar #87
Ideally this would have been smaller changes but the grammar had many many issues.
This adds support to or fixes highlighting for:
Ideally would have more work done on newlines and comments being allowed everywhere but that's an ongoing issue.
Here's what code can now look like using a VS-style theme I put together;
Still remaining before merge:
Dec 30, 2016
Should this be in a patterns array? I was looking into how tmLanguage grammars are structured and this is the only one out of the ~270 I've looked at that has
I'm using a fork of this grammar for something completely different. But it seemed to me that the very essence of scopes is that they are nested.
I can see why having more generalised scopes might not usually matter for syntax-highlighting, but say you wanted – for whatever reason – to highlight nested classes differently to non-nested classes, the scope wouldn't give you that level of detail anymore. You'd only know that a nested class is a class.
Likewise, if a scope doesn't tell you that a method-call is within a class, for instance, then as far as your syntax highlighting is concerned that method-call could be anywhere in the source.
That's really unfortunate that those themes try to style
Overall, I agree that
Other option would be to hunt down the themes and issue PRs. I'll take a look again in the next few days when I get a chance.…
On Sun, Jan 8, 2017 at 9:03 AM Wliu ***@***.***> wrote: That's really unfortunate that those themes try to style meta.class. Meta scopes are meant to be used for autocomplete, not styling (as long as autocomplete could theoretically benefit from those scopes, unlike this <atom/language-c#113>). Overall, I agree that meta.class should exist, but if themes are attempting to style it, then I guess this is the better short-term solution. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <4bf9d94#commitcomment-20400202>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHQp3JTHD9QlY47rwiJt9NAILUEnnvhks5rQRbUgaJpZM4Ldezy> .