New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coloring to grid keywords #121

Merged
merged 2 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@15lnestor
Contributor

15lnestor commented Aug 18, 2017

Description of the Change

Adds syntax coloring for three grid keywords: upleft, downleft, and downright. The keyword "upright" already had syntax highlighting, so this adds it to the other three. Fixes #120. The results can be seen here: http://imgur.com/q902Vk5

Benefits

More cohesive syntax highlighting.

Applicable Issues

Fixes #120

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Aug 18, 2017

Contributor

I feel this should have been included in #99... I'm trusting MDN less and less these days... 😕

@50Wliu LGTM. 👍

Contributor

Alhadis commented Aug 18, 2017

I feel this should have been included in #99... I'm trusting MDN less and less these days... 😕

@50Wliu LGTM. 👍

@Ben3eeE Ben3eeE requested a review from 50Wliu Aug 18, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Aug 18, 2017

Member

This list should remain in alphabetical order.

Member

50Wliu commented Aug 18, 2017

This list should remain in alphabetical order.

@15lnestor

This comment has been minimized.

Show comment
Hide comment
@15lnestor

15lnestor Aug 18, 2017

Contributor

I changed the list to alphabetical @50Wliu.

Contributor

15lnestor commented Aug 18, 2017

I changed the list to alphabetical @50Wliu.

@50Wliu

50Wliu approved these changes Aug 18, 2017

@50Wliu 50Wliu merged commit 45bb77e into atom:master Aug 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment