New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line continuation in other TMCG implementations #124

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@Alhadis
Contributor

Alhadis commented Sep 14, 2017

Description of the Change

This PR has absolutely no bearing on Atom: it's strictly for the benefit of VSCode and GitHub, both of which are using this grammar to highlight CSS code. I'm still not sure how or when the discrepancy started happening: I remember this pattern worked for other grammars I worked on... 馃槥

Anyway, to verify that this fix worked, I installed VSCode in a VirtualBox installation, and modified the VSCode version of the grammar (which was located at C:\Program聽Files\Microsoft聽VS Code\resources\app\extensions\css\syntaxes). Here's the result:

Figure 1

Benefits

It'll fix highlighting on GitHub:

#testcase::before {
	content: 'long string\
	using line continuation';
}

Possible Drawbacks

None. Atom's tests passed without complaint.

Applicable Issues

Fixes #123

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 15, 2017

Member

What is TMCG? TextMate...?

Also, as you can probably guess, I'm not exactly in love with this change, but hey, intercompatibility is pretty important.

Member

50Wliu commented Sep 15, 2017

What is TMCG? TextMate...?

Also, as you can probably guess, I'm not exactly in love with this change, but hey, intercompatibility is pretty important.

@50Wliu 50Wliu merged commit 03d9c5f into atom:master Sep 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 15, 2017

Member

language-css@0.42.6

Member

50Wliu commented Sep 15, 2017

language-css@0.42.6

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Sep 16, 2017

Contributor

What is TMCG? TextMate...?

TMCG = TextMate Compatible Grammar.

Also, as you can probably guess, I'm not exactly in love with this change

Not sure how it makes a difference one way or another. The original pattern was already a hack.

Contributor

Alhadis commented Sep 16, 2017

What is TMCG? TextMate...?

TMCG = TextMate Compatible Grammar.

Also, as you can probably guess, I'm not exactly in love with this change

Not sure how it makes a difference one way or another. The original pattern was already a hack.

@Alhadis Alhadis deleted the Cutlery-Drawer:newline-fix branch Sep 16, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 16, 2017

Member

Not sure how it makes a difference one way or another. The original pattern was already a hack.

Ha, very true :).

Member

50Wliu commented Sep 16, 2017

Not sure how it makes a difference one way or another. The original pattern was already a hack.

Ha, very true :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment