New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-125: Add support for font-display #126

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@abaracedo
Contributor

abaracedo commented Oct 1, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This change adds support for font-display and its possible values.

Alternate Designs

None.

Benefits

Syntax highlight for font-display.

Possible Drawbacks

None.

Applicable Issues

Fixes #125.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 2, 2017

Member

/cc @Alhadis should this property only be syntax-highlighted when in @font-face, or do you think that adds too much complexity?

Also, while the specification is still an Editor's Draft, Chrome + Firefox + Opera support it so I think this can be merged.

Member

50Wliu commented Oct 2, 2017

/cc @Alhadis should this property only be syntax-highlighted when in @font-face, or do you think that adds too much complexity?

Also, while the specification is still an Editor's Draft, Chrome + Firefox + Opera support it so I think this can be merged.

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Oct 2, 2017

Contributor

IMHO, I think that would add a bit too much complexity, especially considering it's still in draft stage.

So, LGTM. 👍

Contributor

Alhadis commented Oct 2, 2017

IMHO, I think that would add a bit too much complexity, especially considering it's still in draft stage.

So, LGTM. 👍

@50Wliu 50Wliu merged commit 0f7e61c into atom:master Oct 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 2, 2017

Member

Thanks @abaracedo!

Member

50Wliu commented Oct 2, 2017

Thanks @abaracedo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment