Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #160 #161

Merged
merged 1 commit into from May 20, 2019
Merged

Fix #160 #161

merged 1 commit into from May 20, 2019

Conversation

@octref
Copy link
Contributor

octref commented May 20, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

As seen in #160, the following code won't be highlighted properly:

@value foo;
.foo

This is caused by my change in #142 to eagerly parse a block of {} in custom at-rules.
My change introduce a new rule that specifically handle single-line custom at-rules ending with ;.

Alternate Designs

n/a

Benefits

Before:

image

After:

image

Possible Drawbacks

Before:

image

After:

image

Although @import-file.css is not valid CSS, I think parsing the @import-file part as at-rule follows the spec closer than original behavior.

Applicable Issues

#160.

@octref octref added the triaged label May 20, 2019
@octref octref merged commit 09c09b5 into atom:master May 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.