Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #163 by not marking media properties as `invalid.deprecated` #165

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@octref
Copy link
Contributor

octref commented Oct 29, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

As detailed in #163, properties should not be scoped as invalid.deprecated easily to cause red syntax highlighting meant for syntax errors.

Alternate Designs

n/a

Benefits

Editors still using the TextMate grammar (including older versions of Atom) would be able to use deprecated media queries without seeing the red flagging (they might be targeting old browsers so their usage would be valid).

Possible Drawbacks

n/a

Applicable Issues

@octref octref mentioned this pull request Oct 29, 2019
1 of 1 task complete
@darangi darangi self-assigned this Nov 11, 2019
@darangi darangi merged commit f7443d8 into atom:master Nov 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.