Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid properties that were not being recognized as supported #166

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@Hyftar
Copy link
Contributor

Hyftar commented Oct 30, 2019

Description of the Change

The following properties were not being tagged as supported properties:

  • row-gap
  • place-items
  • place-self
  • place-content

This pull request fixes this issue by adding the above-mentioned properties to the supported
properties Regex Pattern.

Alternate Designs

None

Benefits

All the new grid properties will now be the same colour as other supported properties.

Possible Drawbacks

None

Applicable Issues

None

@calebmeyer calebmeyer added the triaged label Oct 31, 2019
@darangi darangi self-assigned this Nov 6, 2019
@darangi darangi merged commit 1edca24 into atom:master Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.