Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix CriticMarkup scope names #229
Description of the Change
This PR changes the scope names for CriticMarkup insertions, deletions and substitutions to be more in line with existing naming conventions, in particular language-diff, the official GitHub syntax theme, and the TextMate naming conventions.
It might have been cleaner to change the scope names to something like
The main benefit is better compatibility with existing syntax themes:
As noted earlier, changing the scope names runs the risk of breaking existing themes, but I've tried to avoid this from happening by not removing any of the groups currently in the scope names.