Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfm.cson for Kotlin highlighting #236

Merged
merged 1 commit into from Nov 7, 2018
Merged

Update gfm.cson for Kotlin highlighting #236

merged 1 commit into from Nov 7, 2018

Conversation

@radixdev
Copy link
Contributor

@radixdev radixdev commented Oct 31, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds Kotlin syntax highlighting for code blocks.

Alternate Designs

n/a

Benefits

The Kotlin language can now have syntax highlighting when editing markdown code blocks. This increases readability when editing markdown.

Github supports Kotlin highlighting, see the below.

    // Firebase tokens cannot be obtained on the main thread.
    Thread(Runnable {
      try {
        val token = FirebaseInstanceId.getInstance().getToken("<YOUR_SENDER_ID>", "FCM")
        Appboy.getInstance(applicationContext).registerAppboyPushMessages(token)
      } catch (e: Exception) {
        Log.e(TAG, "Exception while registering Firebase token with Braze.", e)
      }
    }).start()

Possible Drawbacks

I do not foresee any drawbacks to Kotlin language highlighting.

Applicable Issues

#166

@radixdev radixdev mentioned this pull request Oct 31, 2018
@rsese
Copy link
Member

@rsese rsese commented Nov 6, 2018

Sorry about that @radixdev - just wanted to acknowledge that someone from the team will take a look as soon as they can.

Loading

@50Wliu 50Wliu merged commit 631a381 into atom:master Nov 7, 2018
2 checks passed
Loading
@50Wliu
Copy link
Member

@50Wliu 50Wliu commented Nov 7, 2018

Thank you!

Loading

@radixdev radixdev deleted the patch-1 branch Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants