Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Go module and checksum files #156

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
5 participants
@brainsnail
Copy link
Contributor

commented Oct 21, 2018

Description of the Change

In Go 1.11 a new language feature was added called modules. These exist to support removing $GOPATH, encourage repeatable builds and semantic versioning your Go packages. If you want to dig further into what they are, I think the Go team did a great job in their documentation and in the community wiki.

This particular change to the Atom language-go package is to add the two new file types that modules introduced.

Those files are:

  • A checksum file (which has an extension of .sum)
  • A module file (which has an extension of .mod)

Alternate Designs

No particular alternatives stood out.

Benefits

When viewing module and checksum files the version numbers will be highlighted along with the commit hashes. There's some other stuff - like keyword highlighting - that makes it feel a little more polished.

Possible Drawbacks

More regular expressions to maintain for version numbers and checksums.

Applicable Issues

#152 - huge thank you to @pd93 for working on this with me

@rsese

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

Thanks! Someone from the team will take a look as soon as they can.

@lee-dohm

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

@ckaznocha Because of your experience with Go, would you mind reviewing this PR and make sure it won't cause any regressions?

@nathansobo nathansobo self-assigned this Apr 10, 2019

@nathansobo

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Cool. Seems like a nice change. Thanks. Sorry for the wait.

@nathansobo nathansobo merged commit 8486efd into atom:master Apr 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.