New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entity scopes, take two #160

Merged
merged 7 commits into from Sep 20, 2017

Conversation

Projects
None yet
4 participants
@50Wliu
Member

50Wliu commented Apr 29, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Redo of #98, this time taking into account that entities in attributes behave differently. I tried to follow the spec as closely as possible.

Alternate Designs

  • The list of valid entities could be included. I'd rather not do that though.
  • Single-line matches before the begin/end pattern removes the potential for runaway rules, but means that all entities will appear as invalid before they are finished.

Benefits

Realize you're writing an entity before you finish doing so. This also benefits autocomplete-html.

Possible Drawbacks

There may still be room for regressions that I didn't take into account.

Applicable Issues

See #98, #141, #142.

/cc @DavidePastore, @JonathanWolfe - see anything that could potentially break with this version?

@50Wliu 50Wliu added the needs-review label Apr 29, 2017

@DavidePastore

This comment has been minimized.

Show comment
Hide comment
@DavidePastore

DavidePastore May 9, 2017

Contributor

This looks ok for me 👍 Maybe you could add a test with a new line after the "&" character, and check that it works as expected. Thanks for including me in this discussion. 😃

Contributor

DavidePastore commented May 9, 2017

This looks ok for me 👍 Maybe you could add a test with a new line after the "&" character, and check that it works as expected. Thanks for including me in this discussion. 😃

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Jun 8, 2017

Member

Sorry for the late response @DavidePastore. Can you elaborate on what the expected behavior should be, and would you like to see a test for both text and attribute entities, or just text?

Member

50Wliu commented Jun 8, 2017

Sorry for the late response @DavidePastore. Can you elaborate on what the expected behavior should be, and would you like to see a test for both text and attribute entities, or just text?

@JonathanWolfe

This comment has been minimized.

Show comment
Hide comment
@JonathanWolfe

JonathanWolfe Jun 16, 2017

Contributor

LGTM

Contributor

JonathanWolfe commented Jun 16, 2017

LGTM

@DavidePastore

This comment has been minimized.

Show comment
Hide comment
@DavidePastore

DavidePastore Jul 13, 2017

Contributor

@50Wliu Sorry for the delay. I'd like to see a test for both text and attribute entities (for example in the placeholder attribute). For both it should be possibile to have a & character and then a new line. Anyway maybe it could be a redundant test.

Contributor

DavidePastore commented Jul 13, 2017

@50Wliu Sorry for the delay. I'd like to see a test for both text and attribute entities (for example in the placeholder attribute). For both it should be possibile to have a & character and then a new line. Anyway maybe it could be a redundant test.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 20, 2017

Member

⛵️

Member

50Wliu commented Sep 20, 2017

⛵️

@50Wliu 50Wliu merged commit 9fde136 into master Sep 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-entities-take-two branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment