New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta.tag.any.html #172

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 21, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

meta.tag.any.html is a useless pattern that only matches when there is no space between the begin and end tags. It is not used by autocomplete, and meta.tag.other.html matches that pattern just fine. I have also replaced all the other .any's with the actual tag name, meaning meta.tag.structure.any.html is now meta.tag.structure.div.html (or equivalent). Finally, snippets are now prevented from showing up when against an opening tag.

Essentially, it is a lighter version of #93.

Alternate Designs

None.

Benefits

Grammar cleanup and finer-grained scopes.

Possible Drawbacks

This will require autocomplete-html to recognize the new meta scopes before it can be merged.

Applicable Issues

Fixes #25
Supersedes and closes #93

@50Wliu 50Wliu merged commit 6b1a23b into master Sep 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-any-pattern branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment