New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds <script type="application/graphql"> support #191

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@bennypowers
Contributor

bennypowers commented Mar 2, 2018

Description of the Change

This PR adds support for

<script type="application/graphql">
query Query(id: 1) {
  id
  name
}
</script>

Alternate Designs

Rely on JS highlighting

Benefits

Users who wish to embed graphql in HTML (e.g. with polymer-apollo-client, or for documentation) will have code highlighting

Possible Drawbacks

Code might not be sane - this is my first rodeo in atom grammar land.

Applicable Issues

Please double check the code, if tests are needed please point me to relevant examples.

@50Wliu 50Wliu merged commit a8bbb91 into atom:master Mar 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu

This comment has been minimized.

Member

50Wliu commented Mar 6, 2018

Code might not be sane - this is my first rodeo in atom grammar land.

Looks fine to me :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment