Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment handling in EJS and ERB #227

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

commented May 8, 2019

Depends on atom/atom#19279


atom/language-ruby#263 identifies a bug where Ruby line comments can break ERB syntax highlighting. A similar bug exists for JavaScript comments in EJS.

Fixing this bug involves two things:

  1. atom/atom#19279: An enhancement to the addInjectionPoint API in atom/atom
  2. This pull request: An update in language-html to make use of this enhanced API for handling ERB and and EJS in HTML

For full details, please see atom/atom#19279.

jasonrudolph added some commits May 7, 2019

@jasonrudolph jasonrudolph requested a review from maxbrunsfeld May 8, 2019

@jasonrudolph jasonrudolph self-assigned this May 8, 2019

@jasonrudolph jasonrudolph referenced this pull request May 8, 2019

Merged

Improve handling of comment characters in ERB and EJS #19279

4 of 4 tasks complete
@maxbrunsfeld
Copy link
Contributor

left a comment

📈

@jasonrudolph jasonrudolph merged commit 1a9ef30 into master May 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the improve-comment-handling-in-ejs-and-erb branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.