New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Hyperlink" from grammar-selector menu #18

merged 1 commit into from Sep 25, 2017


None yet
2 participants

Alhadis commented Sep 25, 2017

(Copied from atom/language-todo#65)

Description of the Change

Follow-up of atom/grammar-selector#34, which patched the grammar-selector package to hide "internal" or injection-specific grammars from the selection menu. This was recently merged and released in grammar-selector@0.49.6. It's now safe to cut redundant name fields from grammars which shouldn't be listed alongside "real" languages.

See atom/grammar-selector#34 for the original discussion.

/cc @50Wliu

Remove redundant grammar properties
The `name` property of language grammars is only used to provide a human
readable identifier in GUIs. For "injection-only" grammars such as this,
it's not only redundant, but confusing for users who happen across it in
the grammar-selector.

The `fileTypes` array is also optional: its absence is assumed to mean a
grammar has no associated file extensions. An empty array is redundant.

References: atom/grammar-selector#34

@Alhadis Alhadis changed the title from Remove redundant grammar properties to Hide "Hyperlink" from grammar-selector menu Sep 25, 2017

@50Wliu 50Wliu merged commit edf42fe into atom:master Sep 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment