New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add atom:// hyperlinks #21

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@UziTech
Contributor

UziTech commented Mar 12, 2018

Description of the Change

Recognize atom:// uris as valid hyperlinks

Alternate Designs

Benefits

atom:// uris will be recognized as hyperlinks

Possible Drawbacks

Applicable Issues

@UziTech

This comment has been minimized.

Contributor

UziTech commented Apr 11, 2018

@atom any feedback?

@50Wliu

This comment has been minimized.

Member

50Wliu commented May 1, 2018

This doesn't seem too useful without atom/atom#16940. Will merge if/when that PR is merged.

@UziTech

This comment has been minimized.

Contributor

UziTech commented May 1, 2018

@50Wliu atom/atom#16940 only applies to markdown preview and other places that atom has clickable links.

This PR makes atom:// links in a text editor have the correct scope. They don't really have anything to do with each other.

Clicking on an atom:// link inside of atom to open a file is already possible with hyperlink-hyperclick

@50Wliu

This comment has been minimized.

Member

50Wliu commented May 1, 2018

link uses language-hyperlink to determine clickable links.

@UziTech

This comment has been minimized.

Contributor

UziTech commented May 1, 2018

link uses shell.openExternal to open links, so it too won't be affected by atom/atom#16940 (or this PR for that matter since it explicitly only opens http(s):// links)

@UziTech UziTech referenced this pull request May 1, 2018

Merged

add atom: protocol #33

@UziTech

This comment has been minimized.

Contributor

UziTech commented Sep 6, 2018

atom/atom#16940 was merged so this should be good to merge as well as atom/link#33

@50Wliu 50Wliu merged commit f1ac1a4 into atom:master Sep 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@UziTech UziTech deleted the UziTech:patch-1 branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment