New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust invalid scope for uppercase package names #126

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Jan 30, 2018

/cc @sadikovi if you have any ideas for a better scope name.

Closes #117

@sadikovi

This comment has been minimized.

Member

sadikovi commented Jan 30, 2018

Looks great! I think scope name is descriptive and explanatory, no objections.
Tested on locally, applies "warning" highlighting now - that is cool! Thanks!

@50Wliu

This comment has been minimized.

Member

50Wliu commented Jan 30, 2018

⚡️ Fast response time!

@50Wliu 50Wliu merged commit 7a42895 into master Jan 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-change-uppercase-package-scope branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment