New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master branch: add varargs into object-types pattern #134

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@sadikovi
Member

sadikovi commented Mar 6, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR fixes master branch. It was broken after I merged varargs -> capitalised variables pull requests.
The reason it started failing is that for capital variables we check if storage type is followed by variable name. This does not work for ... varargs, e.g. String ... args. So I included it in the regexp. Yes, it is not pretty, but fixes tests and I checked manually with different codes.

Alternate Designs

None, unfortunately, just wanted to fix it. Other ways would be reconsidering how to work with capital variables.

Benefits

Fixes master branch.

Possible Drawbacks

The fix makes object-types scope messy.

Applicable Issues

None

@sadikovi sadikovi changed the title from add varargs into object-types pattern to Fix master branch: add varargs into object-types pattern Mar 6, 2018

@sadikovi

This comment has been minimized.

Member

sadikovi commented Mar 6, 2018

@50Wliu I "patched" the code to pass tests. Could you review this, please?
Sorry for breaking it in the first place.

@50Wliu

This comment has been minimized.

Member

50Wliu commented Mar 6, 2018

Sorry for breaking it in the first place.

No problem, just wait for tests to pass before merging next time :).

@50Wliu 50Wliu merged commit e585a25 into atom:master Mar 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sadikovi sadikovi deleted the sadikovi:fix-master-branch branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment