Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Attempt to fix overlap of generics 2 #93
Description of the Change
In released version of Atom 1.17.0 and in current master branch there is an issue when expression inside
I tried fixing most of the cases, currently I make sure that pattern for object types terminates when
Some of the designs were proposed in #75, but this solution looks fairly simple and does not break existing tests.
Current solution is simple, alternative would require more code, with potentially refactoring large portion of syntax highlighting. This solution also preserves all patterns for generics, and does not have constraint of my previous pull request (generic on single line only).
The change might break some other untested cases.
When debugging this problem, I noted that generics pattern was correct, but generic termination capturing was somehow loose, therefore I decided to essentially enforce rule of terminating generic after
I am happy to try a different approach to this problem, if you want.