New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regular expression named capture group highlighting. #561

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
2 participants
@CentricStorm
Contributor

CentricStorm commented Feb 21, 2018

Description of the Change

  1. Adds support for regular expression named capture group and named backreference syntax highlighting, as the ECMAScript proposal has reached stage 4, and is considered a 'finished proposal'.
  2. Adds unit tests for capture group, non-capture group, named capture group, named backreference and numbered backreference syntax highlighting.

Alternate Designs

None.

Benefits

Enables custom syntax highlighting of regular expression named capture groups and backreferences.

Possible Drawbacks

There weren't previously any unit tests testing regular expression named capture group or named backreference syntax highlighting, so there weren't any to test against.

Applicable Issues

None.

@50Wliu 50Wliu merged commit ceeb27c into atom:master Feb 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CentricStorm CentricStorm deleted the CentricStorm:named-capture-group-support branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment