New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing operators #562

Merged
merged 2 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@mikemcbride
Contributor

mikemcbride commented Mar 1, 2018

Description of the Change

This adds additional symbols to the tree-sitter grammar for keyword.operator.js to have more consistency with the non-tree-sitter grammar. See comparison screenshots when using tree-sitter vs old grammar:

OLD:
image

TREE SITTER:
image

Alternate Designs

It's possible that these were intentionally left out, so we could just leave it the way it is.

Benefits

All operators would have the same classes on them and would be styled consistently.

Possible Drawbacks

There may be situations that I'm not thinking of where one of these operators would be used and we would want a different class on it than operator.

Applicable Issues

Related to #558

cc: @maxbrunsfeld if you have any suggestions here please let me know!

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Mar 1, 2018

Thanks @mmcbride1007! I wasn't very methodical when I initially created these scope mappings; really glad you're taking the time to improve them.

@maxbrunsfeld maxbrunsfeld merged commit 4f5e6eb into atom:master Mar 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mikemcbride

This comment has been minimized.

Contributor

mikemcbride commented Mar 1, 2018

No worries, happy to help!

@mikemcbride mikemcbride deleted the mikemcbride:add-operators branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment