New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self closing elements can also be meta.class #622

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@Ben3eeE
Member

Ben3eeE commented Nov 7, 2018

Description of the Change

Scope jsx_self_closing_element as meta.class if they match the regex. Same as jsx_closing_element and jsx_opening_element.

Benefits

jsx_self_closing_element will be highlighted the same as the jsx_closing_element and jsx_opening_element elements. With the meta.class scope if they match the ^[A-Z] regex.

Possible Drawbacks

Someone wants self closing elements to be entity.name.tag even when they match the regex.

Applicable Issues

/cc: @maxbrunsfeld Found myself writing some JSX and saw this so opening a PR to fix it.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 7, 2018

Makes sense, thanks for the fix!

@Ben3eeE Ben3eeE merged commit 4077ace into master Nov 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ben3eeE Ben3eeE deleted the b3-self-closing-meta branch Nov 7, 2018

Ben3eeE added a commit to atom/language-typescript that referenced this pull request Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment