New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between commas and periods. #623

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@CentricStorm
Contributor

CentricStorm commented Nov 7, 2018

Description of the Change

The comma and period currently both have the same meta.delimiter scope, which makes it impossible to style them differently. This change modifies both so that they can be distinguished: meta.delimiter.comma and meta.delimiter.period.

Alternate Designs

The keyword.operator.accessor scope would be more appropriate for the period as per the ECMAScript specification, but that might not work well with some themes.

Benefits

It becomes possible to apply different styles to commas and periods.

Possible Drawbacks

Applicable Issues

@Ben3eeE Ben3eeE requested a review from maxbrunsfeld Nov 7, 2018

@Ben3eeE Ben3eeE merged commit 84d844c into atom:master Nov 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Nov 7, 2018

Thanks for contributing 🙇

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Nov 7, 2018

Thanks @CentricStorm!

Ben3eeE added a commit to atom/language-typescript that referenced this pull request Nov 7, 2018

@CentricStorm CentricStorm deleted the CentricStorm:update-comma-period branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment