Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove invalid string highlighting from TextMate grammar #642
Description of the Change
@Alhadis proposed the solution of removing the "rule which highlights unterminated strings as errors" which @50Wliu suggested would probably be fine as the TextMate grammars are no longer actively maintained:
This change only affects the TextMate grammar as this is the grammar Linguist uses as tree-sitter grammars are not currently supported.
As this change only affects the TextMate grammar, there is a risk that the editor behaviour may vary slightly from the representation on GitHub.com for as long as we use the TextMate grammar.
See github/linguist#3044 for further details of the problem we're trying to resolve.
Yup. I've gone back to @Alhadis to see if he's got a better idea or implementation method as I agree, it's not ideal, however it's certainly waaaay better than all the red... like in this PR https://github.com/peterbe/whatsdeployed/pull/81/files
Yup, but this would only affect GitHub and Atom users that have the treesitter grammars disabled. An alternate solution is waaay too complex and requires changes to Atom.