Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'forEach' snippet #664

Merged
merged 1 commit into from Nov 13, 2019
Merged

Add a 'forEach' snippet #664

merged 1 commit into from Nov 13, 2019

Conversation

@pbsds
Copy link
Contributor

pbsds commented Oct 31, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

It is the simple addition of a single snippet. I did not find tests for these in previously merged commits of the same nature.

Alternate Designs

I could instead use an anonymous function instead of arrow notation, but after a quick check on caniuse.com i decided against it.

Benefits

sanity++

Possible Drawbacks

Not all browsers may support arrow notation

Applicable Issues

@calebmeyer calebmeyer added the triaged label Oct 31, 2019
@darangi darangi self-assigned this Nov 13, 2019
@darangi

This comment has been minimized.

Copy link
Contributor

darangi commented Nov 13, 2019

@pbsds, This is awesome! ❤️

@darangi darangi merged commit bb462d6 into atom:master Nov 13, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.