Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope link as string and add scope for " #73

Merged
merged 2 commits into from May 17, 2019

Conversation

Projects
None yet
2 participants
@Ben3eeE
Copy link
Member

commented May 17, 2019

Description of the Change

This PR adds the string.quoted.double scope as discussed in #68, specifically #68 (comment)

It also adds a scope for an anonymous " node as made possible in atom/atom#19336

Alternate Designs

N/A

Benefits

Closer to TextMate with the benefits of tree-sitter

Possible Drawbacks

We still scope " as markup.underline.link. Textmate doesn't, it just scopes it as string.quoted.double. A lot of themes style any markup.underline.link as a link. So generally quotes are still styled as a link.

Applicable Issues

N/A. Cleaning up after adding tree-sitter-json

/cc: @50Wliu @nathansobo @caleb531

@Ben3eeE

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

I initially added the begin scope to anonymous " nodes because atom-material-syntax required it to style " as normal. But I removed it now because we cant scope both the starting " and ending " as begin. And there is no way to differentiate them in tree-sitter.

I don't know why we would differentiate the start and end character with scopes when we have access to the syntax tree so I think changing atom-material-syntax is a better option in this case.

@nathansobo nathansobo merged commit ee7c0cc into master May 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the b3-fix-json branch May 17, 2019

@nathansobo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

❤️ Thanks so much for following up on this one @Ben3eeE. Published as language-json@1.0.1. I will upgrade on master and 1.38-releases. Keep up the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.