Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperlink highlighting #76

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@Aerijo
Copy link
Member

commented Jun 12, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Changes the regex to a string, which is then turned into a regex itself later on.

Alternate Designs

na

Benefits

correctness

image

Possible Drawbacks

na

Applicable Issues

fixes #75

@Aerijo

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

image

Looks like CSON and regex don't mix as expected. The fact that so much wrong still ends up "right" is amusing. Like, why would anyone want an object passed to a regex constructor to make a regex with the default object string, that happens to form the regex pattern to match any character in object Object.

@rafeca

rafeca approved these changes Jun 12, 2019

Copy link
Contributor

left a comment

Thanks for sending a fix so quickly!! 😍

@rafeca rafeca merged commit a80efcb into atom:master Jun 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JosefBredereck

This comment was marked as off-topic.

Copy link

commented on cb85cf0 Jun 13, 2019

Something isn't working correctly. Everything is marked as a link now.

This comment was marked as off-topic.

Copy link
Member Author

replied Jun 13, 2019

@JosefBredereck Please make an issue with the template filled out. Safe mode confirmation, steps to reproduce, and version numbers are especially important.

For what it's worth, Atom 1.38.1 in safe mode displays JSON's as expected for me, on Ubuntu and macOS.

This comment was marked as off-topic.

Copy link

replied Jun 13, 2019

Sorry, your answer already helped, I disabled the "Use Tree Sitter Parser" option, now everything is fine.

This comment was marked as off-topic.

Copy link
Member Author

replied Jun 13, 2019

@JosefBredereck You disabled Tree-sitter parsers? That is meant to be a temporary fix, as those parsers offer better performance, code folding support, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.