New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .rc, themerc and gtkrc from file-types list #88

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@Alhadis
Contributor

Alhadis commented Mar 22, 2018

The association with these filenames was added in #57, but I can't fathom why. Each of them are closer to INI configs and shell-scripts rather than Less:

As for .rc, well... that extension is predominantly used by shell-scripts (particularly on Plan 9), but its use goes far beyond that. At no point has it ever been connected with stylesheets.

/cc @50Wliu, @fusion809

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Oct 1, 2018

@50Wliu do you have any comments on this?

@fusion809

This comment has been minimized.

Contributor

fusion809 commented Oct 1, 2018

Well GTK configs, iirc, are meant to be written in a CSS/Less-style format, but I'm easy either way as I've largely ditched Atom in favour of Vim and VSCode. Thanks for informing me of this though, you's could have gone behind my back instead so I appreciate you's keeping me in the loop.

@50Wliu

This comment has been minimized.

Member

50Wliu commented Oct 1, 2018

Hmm, that was a long time ago, but this seems like a good change.

@50Wliu 50Wliu merged commit 6e0c415 into atom:master Oct 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment