New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add master pattern #29

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 21, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This adds a master pattern, #mustache, that includes all other patterns that should be injected into HTML. This is to make it easier for other grammars to include language-mustache, as injections are not included.

Also, I fixed the SQL Mustache grammar.

Alternate Designs

Splitting up the grammar files, but I can't think of a good scope name for standalone Mustache.

Benefits

Including language-mustache can now be done through 'include': 'text.html.mustache#mustache'.

Possible Drawbacks

None.

Applicable Issues

Closes #26

/cc @caleb531

50Wliu added some commits Sep 21, 2017

@50Wliu 50Wliu merged commit c160010 into master Sep 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-add-master-pattern branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment