New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for handlebars `{{!--` style comments #31

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@baroquon
Contributor

baroquon commented Oct 20, 2017

Description of the Change

This adds support for handlebars style block comments

{{!-- this is a comment that {{contains}} some handlebars
  and is terminated with double dash + double braces: --}}

Benefits

Previously a handlebars style bock comment that contained a handlebars expression was not properly highlighted.

Applicable Issues

This PR resolves #30.

Show outdated Hide outdated grammars/mustache.cson
@baroquon

This comment has been minimized.

Show comment
Hide comment
@baroquon

baroquon Oct 20, 2017

Contributor

@50Wliu sorry about that. Should be corrected now.

Contributor

baroquon commented Oct 20, 2017

@50Wliu sorry about that. Should be corrected now.

@50Wliu

50Wliu approved these changes Oct 20, 2017

@50Wliu 50Wliu merged commit 65451d8 into atom:master Oct 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment