New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerlJam™ - Add scopes, fix scopes, add missing stuff, etc… #90

merged 10 commits into from Oct 19, 2017


None yet
4 participants

Alhadis commented Oct 19, 2017

Description of the Change

This is a combination of clean-ups and corrections. Each commit has been kept atomic for easier review, and I've documented my rationale for each change in the commit notes. Check the revision history for details. =)

Applicable Issues

Fixes #88

Alhadis added some commits Oct 19, 2017

Delete redundant `.coffeelintignore` manifest
There is no `spec/fixtures` directory, and there probably never was.

* atom/language-gfm@181e691
* atom/language-javascript#464
* atom/language-todo@7d9c2bb
Fix misclassification of spec-files on GitHub
Since backslashes need to be double-escaped for CoffeeScript, the tests
for modeline-matching have been incorrectly picked up by GitHub.

This PR fixes the skewed language stats by adding an Emacs modeline that
has higher priority over `-*- this: syntax -*-`. Introduced by gh-76.
Update list of associated file extensions
* Perl 5: Removed `vcl`; language is unrelated. See github/linguist#3857
* Perl 6: Added `.pod6`. See github/linguist#3366
Add pattern-matching for pragma directives
See perldiag(1) for detailed info.
Add pattern-matching for version literals
This keeps `use v5.15` from being highlighted as a floating-point value.
Tokenises the ellipsis statement in subroutines
See: perlsyn(1), or
Add missing punctuation scopes to brackets/braces
Resolves #88 by scoping `()`, `{}` and `[]` pairs.

Unfortunately, it isn't feasible to establish the context of matched
bracket pairs, and would likely involve a total rehaul of the entire
grammar structure. At which point, we're better of rewriting it from
scratch anyway.

@Fank Fank self-requested a review Oct 19, 2017

@Fank Fank merged commit 1e3a9e1 into atom:master Oct 19, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded

@Fank Fank removed the needs-review label Oct 19, 2017


This comment has been minimized.

Show comment
Hide comment

Fank Oct 19, 2017


@Alhadis version published 0.38.0


Fank commented Oct 19, 2017

@Alhadis version published 0.38.0


This comment has been minimized.

Show comment
Hide comment

Alhadis Oct 19, 2017




Alhadis commented Oct 19, 2017


@Alhadis Alhadis deleted the Cutlery-Drawer:perl-jam branch Oct 19, 2017

@@ -7,7 +7,6 @@

This comment has been minimized.


dcmoore-gd Oct 19, 2017


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment