Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grammar begin/match #351

Closed
roblourens opened this issue Jan 21, 2019 · 2 comments

Comments

@roblourens
Copy link
Contributor

commented Jan 21, 2019

Should this be match instead of begin?

'begin': '(?i)\\b(isset|unset|eval|empty|list)\\b'

@Ingramz

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2019

It can be either per specification, meaning if there is no end, it won't loop. But it would be less confusing if it was match instead.

@roblourens

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Fixed in #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.