New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct __toString capitalisation #275

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@tpunt
Contributor

tpunt commented Sep 18, 2017

Description of the Change

Correct the capitalisation of the __toString magic method. The other magic methods follow the camelCase convention, so this one should too.

E.g:
incorrect __toString capitalisation

@Ingramz

This comment has been minimized.

Show comment
Hide comment
@Ingramz

Ingramz Sep 18, 2017

Contributor

I approve the change to maintain consistency, however it should make little difference functionality wise to the current (v0.40.0 and up) grammar as that part is case insensitive.

@tpunt are you running an older version of Atom or language-php package by chance?

Contributor

Ingramz commented Sep 18, 2017

I approve the change to maintain consistency, however it should make little difference functionality wise to the current (v0.40.0 and up) grammar as that part is case insensitive.

@tpunt are you running an older version of Atom or language-php package by chance?

@50Wliu 50Wliu merged commit 354b42a into atom:master Sep 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpunt

This comment has been minimized.

Show comment
Hide comment
@tpunt

tpunt Sep 18, 2017

Contributor

@Ingramz It would appear so. Looks like I should start upgrading my dev environment... Thanks anyway.

Contributor

tpunt commented Sep 18, 2017

@Ingramz It would appear so. Looks like I should start upgrading my dev environment... Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment