New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .theme file extension #283

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@davisben
Contributor

davisben commented Sep 30, 2017

Description of the Change

Drupal 8 themes use the .theme extension for PHP files. This change adds that as a valid extension.

Alternate Designs

None considered.

Benefits

Proper syntax highlighting for .theme files.

Possible Drawbacks

None come to mind.

@Ingramz

I couldn't find a sensible reason why Drupal devs have decided going with such file extension especially because it's a regular PHP file, but otherwise 👌.

@50Wliu 50Wliu merged commit aa09512 into atom:master Oct 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davisben davisben deleted the davisben:theme-extension branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment