New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize namespaces when using the scope resolution operator #288

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Oct 16, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Simply uses the [a-z_\\x{7f}-\\x{ff}\\\\][a-z0-9_\\x{7f}-\\x{ff}\\\\]* that is commonly found elsewhere throughout language-php.

Alternate Designs

None.

Benefits

Namespaces before a scope resolution operator will be tokenized properly.

Possible Drawbacks

None.

Applicable Issues

Fixes #284
Supersedes and closes #281

@50Wliu 50Wliu merged commit 3e21c92 into master Oct 16, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-scope-resolution-namespaces branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment