New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove potential zero-width injection pattern #291

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Oct 19, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The removed pattern matches and tokenizes leading/trailing whitespace for php blocks. This is rather useless since Atom already does that. It was also potentially zero-width if it matched at the start of a line, meaning that Atom would break out of the rule, or worse, enter an infinite loop.

Alternate Designs

Fix the rule. This was briefly considered and discarded because well, it's redundant.

Benefits

Removes an unnecessary rule.

Possible Drawbacks

None.

Applicable Issues

Fixes #259

/cc @Ingramz

@50Wliu 50Wliu merged commit 28fb4f8 into master Oct 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-infinite-injection-loop branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment