New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect escaping double quotes only in double quoted strings #298

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@Ingramz
Contributor

Ingramz commented Nov 20, 2017

Description of the Change

Although the manual does not specify this, the sequence \" will only escape in double quoted strings. In rest of the string types it is interpreted verbatim.

Also removed the inaccurate escape sequence from backtick-strings and fixed/enhanced the heredoc specs.

Alternate Designs

None considered.

Benefits

More accurate escaped character detection.

Possible Drawbacks

None that I can think of.

Applicable Issues

None

@50Wliu 50Wliu merged commit 2f3c4b1 into atom:master Dec 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment