New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP tags being injected into PHP source code #342

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@Ingramz
Contributor

Ingramz commented Nov 2, 2018

Description of the Change

This pull request excludes PHP tag scopes meta.embedded.block.php and meta.embedded.line.php from injections when PHP code is used within script tags or inline HTML similarly to the base case that does not involve HTML.

Alternate Designs

N/A

Benefits

N/A

Possible Drawbacks

N/A

Applicable Issues

Fixes #326

@50Wliu 50Wliu merged commit f84efb4 into atom:master Nov 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment