Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for small issues: ternary, ereg, comments w/ closures #369

Merged
merged 6 commits into from Oct 18, 2019

Conversation

@KapitanOczywisty
Copy link
Contributor

KapitanOczywisty commented Aug 29, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Fixed ternary operator with double colon #356 (w/ test spec)
Ereg functions won't match part of function name #353
Comments in closures are now properly colored #322 (w/ test spec)

Alternate Designs

None

Benefits

Better and happier life

Possible Drawbacks

None

Applicable Issues

fix #356, fix #353, fix #322

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Aug 29, 2019

Thanks for this as well 👍 As mentioned in #368 (comment), can you add tests to help guard against future regressions?

@rsese rsese added the needs-testing label Aug 29, 2019
@KapitanOczywisty

This comment has been minimized.

Copy link
Contributor Author

KapitanOczywisty commented Aug 30, 2019

Will try, however I'm not familiar with tests in atom. First I need to read a bit about that.

@KapitanOczywisty

This comment has been minimized.

Copy link
Contributor Author

KapitanOczywisty commented Aug 31, 2019

@rsese I've added tests for ternary and closures. However, there is no reasonable test to add for ereg functions, I could only prevent that exact case which is unlikely to occur again.

Unless you need anything else I'm considering this pull request ready. Now to second one.

@KapitanOczywisty

This comment has been minimized.

Copy link
Contributor Author

KapitanOczywisty commented Aug 31, 2019

Found one more error with exec-related functions, similar to ereg.

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Sep 3, 2019

Thanks @KapitanOczywisty 🙇! Though we can't promise a specific timeframe, someone from the team will take a look here and in #368 as soon as they can.

@rsese rsese added triaged and removed needs-testing labels Sep 3, 2019
@lkashef lkashef merged commit e4fe195 into atom:master Oct 18, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.