New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async indent #214

Merged
merged 5 commits into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@kbrose
Contributor

kbrose commented Oct 18, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Add async syntax to indentation regex

Alternate Designs

None.

Benefits

Python 3.5 introduced async syntax, this will allow proper indentation when using said syntax.

Possible Drawbacks

None.............................?

Applicable Issues

Not an issue, but this PR #152 has been open for > 1 year.

@50Wliu 50Wliu merged commit ccd1b74 into atom:master Oct 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kbrose kbrose deleted the kbrose:async-indent branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment