New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase hex in str #215

Merged
merged 3 commits into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@kbrose
Contributor

kbrose commented Oct 18, 2017

Description of the Change

Add lowercase letters to hex characters inside strings.

Alternate Designs

None

Benefits

Proper highlighting of lowercase hex letters such as

s = '\x0a'

Possible Drawbacks

None..................?

Applicable Issues

#200

Stagnant PR accomplishing same thing w/o tests: #201

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 18, 2017

Member

Thanks, looks good. I'll merge once you revert the unrelated auto-indent changes.

Member

50Wliu commented Oct 18, 2017

Thanks, looks good. I'll merge once you revert the unrelated auto-indent changes.

@kbrose

This comment has been minimized.

Show comment
Hide comment
@kbrose

kbrose Oct 21, 2017

Contributor

@50Wliu done.

Contributor

kbrose commented Oct 21, 2017

@50Wliu done.

@50Wliu 50Wliu merged commit 64d7f73 into atom:master Oct 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kbrose kbrose deleted the kbrose:lowercase-hex-in-str branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment