New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level up string formatting #224

merged 5 commits into from Jan 21, 2018


None yet
1 participant

50Wliu commented Jan 21, 2018


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The string formatting rules have been updated according to the two official specs, for the deprecated % style and for the new {} style.

Alternate Designs



By being in line with the specs, a number of formatting-related bugs should be fixed.

Possible Drawbacks

  • The % spec is a bit ambiguous (for example, what constitutes a "sequence of characters"?) so it is possible that I misinterpreted parts of it.
  • While not explicitly stated in the {} spec, it appears that nested formatting is possible. That is not yet supported by this PR.

Applicable Issues

Fixes #211
Fixes #115
Fixes #71

50Wliu added some commits Jan 21, 2018

50Wliu added some commits Jan 21, 2018

Punt on $self highlighting for now
If it turns out people want it it'll be trivial to add

@50Wliu 50Wliu merged commit 13f594c into master Jan 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-string-formatting branch Jan 21, 2018

@Arcanemagus Arcanemagus referenced this pull request Mar 16, 2018


Escaped quotes in SQL strings break highlighting #240

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment