New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize binary strings #232

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Jan 22, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Python 3.0 introduced binary strings (PEP-3112), which this PR adds support for.

Alternate Designs

None.

Benefits

Binary strings will be tokenized properly.

Possible Drawbacks

None.

Applicable Issues

None.

@50Wliu

This comment has been minimized.

Member

50Wliu commented Jan 22, 2018

Note that while testing this I noticed that the type/quote for loops are not working correctly and the tests all use the last iteration. I am investigating why.

50Wliu added some commits Jan 22, 2018

@50Wliu 50Wliu merged commit 10980d3 into master Jan 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-binary-strings branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment