New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all docstrings are SQL #247

merged 1 commit into from Mar 28, 2018


None yet
1 participant

50Wliu commented Mar 28, 2018

My fix in #243 was causing all docstrings to be tokenized as meta.embedded.sql. I fixed that by only adding that scope when SQL is detected and adding some basic docstring tests.

@50Wliu 50Wliu merged commit 4ac80a7 into master Mar 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-not-all-docstrings-are-sql branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment