New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lambda parsing issues #246 #253

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@falcondai
Contributor

falcondai commented Apr 19, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Capture lambda with \b(lambda)\s?+

Alternate Designs

Benefits

Resolve #246

Possible Drawbacks

Applicable Issues

#246

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Apr 24, 2018

Thanks!

@maxbrunsfeld maxbrunsfeld merged commit 239d7cd into atom:master Apr 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@falcondai

This comment has been minimized.

Contributor

falcondai commented Apr 24, 2018

@maxbrunsfeld I overlooked one issue with my proposed changes and it causes an issue when parsing lambda_not (due to the new whitespace match). Added another test case and a better regex for lambda. Submitting a PR

@kbrose

This comment was marked as outdated.

Contributor

kbrose commented May 19, 2018

Can we publish a new version of language-python? I was happy to see that this has been fixed in the code, but atom 1.27 released a few days ago still has incorrect lambda highlighting. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment